Simplify API of data-managing widgets a bit, and document #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On copy-paste (or cut-and-paste), Android Studio tries to automatically adjust indentation, and sometimes it makes a mess of it. That happened when this code was moved from widgets/app.dart.
Rather than having the rest of the app refer to PerAccountRoot for one aspect of this API and PerAccountStoreWidget for another.
Just like we did for per-account data in the previous commit.
This was referenced Mar 14, 2023
|
LGTM, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step toward #21 and #13.