-
Notifications
You must be signed in to change notification settings - Fork 314
KaTeX(5/n): Handle 'position' and ensure required inline styles for big operators #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rajveermalviya
wants to merge
18
commits into
zulip:main
Choose a base branch
from
rajveermalviya:pr-tex-content-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent string interpolation being evaluated during release build. Especially useful in later commit where it becomes more expensive.
And rename previous type to KatexSpanNode, also while making it a subtype of KatexNode.
And inline the behaviour for `inline: false` in MathBlock widget.
This applies the correct font scaling if the KaTeX content is inside a header.
In KaTeX HTML it is used to set the baseline of the content in a span, so handle it separately here.
Implement handling most common types of `vlist` spans.
No changes on the widget side, because all the offsets currently applied (we only support `top`) are relative to widgets original position, using `Container.transform`. Same reason the parser currently only accepts `relative` as the value.
d060034
to
1b2a740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1452 because it depends on a commit from it namely: fef8a60 content: Handle 'top' property in KaTeX span inline style.
Related: #46.