-
Notifications
You must be signed in to change notification settings - Fork 310
autocomplete: Add code to recognize @-mention syntax in the content input #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5a41d6e
autocomplete: Implement `toString` on MentionAutocompleteQuery
chrisbobbe 41e17ad
autocomplete: Cancel in-progress computations after [dispose] is called
chrisbobbe 3db7e9a
autocomplete: Extend content controller with `autocompleteIntent` method
chrisbobbe 8aec8f7
compose [nfc]: Pass message list's `narrow` to StreamComposeBox
chrisbobbe 466018f
compose: Maintain a MentionAutocompleteView when controller reports i…
chrisbobbe 519a6c5
autocomplete [nfc]: Add `silent` to MentionAutocompleteQuery
chrisbobbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part actually still belongs after the regexp match succeeds.
Otherwise we get a peculiar behavior where if you're in a situation like (in the tests' notation)
~@[email protected]^
and you start extending the selection left, the autocomplete state remains unchanged for a while:
~@someone@^example.com^
but then once you get past the
@
that was in the middle of the query:@someone^@example.com^
@^[email protected]^
the autocomplete goes away, even though you've still only selected text that was within the query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right! Thanks for the catch; I'll fix this and add test cases from those helpful examples you gave.