Adjust compose hints toward "general chat" #1425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is trivial for now, but provides a home for logic to be added next. In particular this separates the computation of how the topic should appear in the hint text from what the topic should be in the API, in `destination`.
…re; TODO fix tests, add tests
|
These changes got incorporated into #1364, and that's now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by these comments on #1364, toward #1250:
#1364 (comment)
#1364 (comment)
@PIG208 I recommend updating #1364 like so:
Include the first commit:
940aeaf compose [nfc]: Pull out method for computing topic for hint text
Complete the second commit:
750a233 WIP compose: Omit "(no topic)" from hint when not allowed to send there; TODO fix tests, add tests
by taking some of the tests from this commit in the other PR which includes a similar behavior change:
442d112 compose: Change content input hint text if topic is empty and mandatory
Rebase the remainder of what's done in the other PR's main two commits:
442d112 compose: Change content input hint text if topic is empty and mandatory
dcaf165 compose: Support sending to empty topic
to go atop those changes and use this
_hintTopicmethod.