Skip to content

compose: Support editing an already-sent message #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lakshya1goel
Copy link
Contributor

@lakshya1goel lakshya1goel commented Jan 30, 2025

Fixes: #126

Video Recording

WhatsApp.Video.2025-02-03.at.2.26.56.PM.mp4

Screenshots

Step 1 Step 2 Step 3
Step 1 Step 2 Step 3
Success Failure
Success Failure

@lakshya1goel lakshya1goel marked this pull request as draft January 30, 2025 15:14
@lakshya1goel lakshya1goel marked this pull request as ready for review February 3, 2025 15:00
@lakshya1goel lakshya1goel marked this pull request as draft February 4, 2025 19:25
@gnprice
Copy link
Member

gnprice commented Feb 6, 2025

Thanks @lakshya1goel for picking this up!

This will be an exciting feature but also a complex one, which is a major reason why it's in the M6 Post-launch milestone rather than M5 Launch or earlier. Yesterday after looking back at the last few weeks' progress, I determined we should start focusing more strictly on the M5a and M5 Launch milestones in order to get the app launched to everyone on schedule. Given that, let's put this PR on hold for now until the launch is ready.

@gnprice
Copy link
Member

gnprice commented Mar 17, 2025

Closing this because this is a complex issue, and I think this PR doesn't yet have a lot in common with a direction that I'd want to see for an implementation of this that we merge. More context here: #126 (comment)

@lakshya1goel thanks for trying this out; I'd encourage first revising your reviewed PRs, and then taking a look at our other launch issues. On the board I see at least one "help wanted" launch issue still unclaimed.

@gnprice gnprice closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compose: Support editing an already-sent message
2 participants