Skip to content

Handle TeX blocks with blank lines #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnprice opened this issue Dec 11, 2024 · 0 comments · Fixed by #1156
Closed

Handle TeX blocks with blank lines #1130

gnprice opened this issue Dec 11, 2024 · 0 comments · Fixed by #1156
Assignees
@rajveermalviya
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone
M5a: Launch blockers

Comments

@gnprice
Copy link
Member

gnprice commented Dec 11, 2024

Sylwester Cyba discovered that some LaTeX math blocks are unimplemented syntax.

In particular this message reproduces the issue (example):

```math
a

b
```

Without the blank line, the issue doesn't repro.

This situation doesn't seem super common, but we should handle it.

I haven't yet investigated to determine what's different in the HTML that causes it to not match the structures we're looking for.
@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Dec 11, 2024
@gnprice gnprice added this to the M5: Launch milestone Dec 11, 2024
@rajveermalviya rajveermalviya self-assigned this Dec 11, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Dec 13, 2024
@rajveermalviya
content: Handle multiple math blocks in <p>
247e111 
Fixes: zulip#1130
@rajveermalviya rajveermalviya mentioned this issue Dec 13, 2024
Merged
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 6, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
9d222da 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 6, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
f4dde28 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 7, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
5f0bfa1 
Fixes: zulip#1130
@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 12, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
127395d 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 12, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
d072321 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 12, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
84ff50f 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 13, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
c724dee 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 13, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
664ab54 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 13, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
b6036c9 
Fixes: zulip#1130
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 14, 2025
@rajveermalviya
content: Move math block parsing to the callers of parseBlockContent
6b40f36 
Prepares for zulip#1130, this commit is almost NFC with only
difference that, in an error case we previously emitted a
`ParagraphNode` containing an `UnimplementedInlineContentNode`
(along with any adjacent nodes), now we emit a single
`UnimplementedBlockContentNode` instead.
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 14, 2025
@rajveermalviya
content: Handle multiple math blocks in <p>
1d737e4 
Fixes: zulip#1130
gnprice pushed a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 14, 2025
@rajveermalviya @gnprice
content: Move math block parsing to the callers of parseBlockContent
c87d48b 
Prepares for zulip#1130, this commit is almost NFC with only
difference that, in an error case we previously emitted a
`ParagraphNode` containing an `UnimplementedInlineContentNode`
(along with any adjacent nodes), now we emit a single
`UnimplementedBlockContentNode` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajveermalviya rajveermalviya

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Flutter app
Status: Done
Milestone
M5a: Launch blockers
Development

Successfully merging a pull request may close this issue.

content: Handle multiple math blocks in <p> rajveermalviya/zulip-flutter
2 participants
@gnprice @rajveermalviya