Skip to content

Commit c514b59

Browse files
PIG208gnprice
authored andcommitted
FIXME LINK api/notif [nfc]: Cut comment on FcmMessageChannelRecipient.streamId, relying on server 5+, FL 115+.
See "Feature level 115" from Zulip API changelog: https://zulip.com/api/changelog See also: https://github.com/zulip/zulip/issues/ 18067 Signed-off-by: Zixuan James Li <[email protected]>
1 parent 7a4c229 commit c514b59

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lib/api/notifications.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,9 @@ sealed class FcmMessageRecipient {
177177
@JsonSerializable(fieldRename: FieldRename.snake, createToJson: false)
178178
@_IntConverter()
179179
class FcmMessageChannelRecipient extends FcmMessageRecipient {
180-
// Sending the stream ID in notifications is new in Zulip Server 5.
181-
// But handling the lack of it would add complication, and we don't strictly
182-
// need to -- we intend (#268) to cut pre-server-5 support before beta release.
183-
// TODO(server-5): cut comment
184180
final int streamId;
185181

186-
// Current servers (as of 2023) always send the stream name. But
182+
// Current servers (as of 2025) always send the stream name. But
187183
// future servers might not, once clients get the name from local data.
188184
// So might as well be ready.
189185
@JsonKey(name: 'stream')

0 commit comments

Comments
 (0)