action_sheet [nfc]: Renames/doc changes to fit context-menu Figma component

The Figma has a "context menu" component (see link in new dartdoc),
which _showBottomSheet has been a good fit for. (See e.g.
ZulipMenuItemButtonStyle.menu, and design variables like
contextMenuItemBg.) We're about to make that fit a bit closer, so it
makes sense to change the name (and some helpers' names) and add a
dartdoc.

Author: chrisbobbe

lib/widgets/action_sheet.dart

@@ -34,10 +34,14 @@ import 'text.dart';
 import 'theme.dart';
 import 'topic_list.dart';
 
-void _showActionSheet(
+/// Shows a "context menu" in the style of the Figma component with that name.
+///
+/// See Figma:
+///   https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3479-26262&m=dev
+void _showContextMenu(
   BuildContext pageContext, {
   Widget? header,
-  required List<Widget> optionButtons,
+  required List<Widget> buttons,
 }) {
   // Could omit this if we need _showActionSheet outside a per-account context.
   final accountId = PerAccountStoreWidget.accountIdOf(pageContext);
@@ -91,21 +95,21 @@ void _showActionSheet(
                           color: designVariables.bgContextMenu,
                           child: SingleChildScrollView(
                             padding: const EdgeInsets.symmetric(vertical: 8),
-                            child: MenuButtonsShape(buttons: optionButtons)))),
+                            child: MenuButtonsShape(buttons: buttons)))),
                         const BottomSheetDismissButton(style: BottomSheetDismissButtonStyle.cancel),
                       ]))),
               ]))));
     });
 }
 
-/// A header for a bottom sheet with a multiline UI string.
+/// A header for a context menu with a multiline UI string.
 ///
 /// Assumes 8px padding below the top of the bottom sheet.
 ///
 /// Figma:
 ///   https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3481-26993&m=dev
-class BottomSheetHeaderPlainText extends StatelessWidget {
-  const BottomSheetHeaderPlainText({super.key, required this.text});
+class ContextMenuHeaderPlainText extends StatelessWidget {
+  const ContextMenuHeaderPlainText({super.key, required this.text});
 
   final String text;
 
@@ -126,7 +130,7 @@ class BottomSheetHeaderPlainText extends StatelessWidget {
   }
 }
 
-/// A button in an action sheet.
+/// A button in a context menu.
 ///
 /// When built from server data, the action sheet ignores changes in that data;
 /// we intentionally don't live-update the buttons on events.
@@ -140,8 +144,8 @@ class BottomSheetHeaderPlainText extends StatelessWidget {
 /// (Even if we did live-update the buttons, it's possible anyway that a user's
 /// action can race with a change that's already been applied on the server,
 /// because it takes some time for the server to report changes to us.)
-abstract class ActionSheetMenuItemButton extends StatelessWidget {
-  const ActionSheetMenuItemButton({super.key, required this.pageContext});
+abstract class ContextMenuItemButton extends StatelessWidget {
+  const ContextMenuItemButton({super.key, required this.pageContext});
 
   IconData get icon;
   String label(ZulipLocalizations zulipLocalizations);
@@ -241,24 +245,24 @@ void showChannelActionSheet(BuildContext context, {
   final pageContext = PageRoot.contextOf(context);
   final store = PerAccountStoreWidget.of(pageContext);
 
-  final optionButtons = <ActionSheetMenuItemButton>[];
+  final buttons = <ContextMenuItemButton>[];
 
   final unreadCount = store.unreads.countInChannelNarrow(channelId);
   if (unreadCount > 0) {
-    optionButtons.add(
+    buttons.add(
       MarkChannelAsReadButton(pageContext: pageContext, channelId: channelId));
   }
 
-  optionButtons.add(
+  buttons.add(
     TopicListButton(pageContext: pageContext, channelId: channelId));
 
-  optionButtons.add(
+  buttons.add(
     CopyChannelLinkButton(channelId: channelId, pageContext: pageContext));
 
-  _showActionSheet(pageContext, optionButtons: optionButtons);
+  _showContextMenu(pageContext, buttons: buttons);
 }
 
-class MarkChannelAsReadButton extends ActionSheetMenuItemButton {
+class MarkChannelAsReadButton extends ContextMenuItemButton {
   const MarkChannelAsReadButton({
     super.key,
     required this.channelId,
@@ -282,7 +286,7 @@ class MarkChannelAsReadButton extends ActionSheetMenuItemButton {
   }
 }
 
-class TopicListButton extends ActionSheetMenuItemButton {
+class TopicListButton extends ContextMenuItemButton {
   const TopicListButton({
     super.key,
     required this.channelId,
@@ -306,7 +310,7 @@ class TopicListButton extends ActionSheetMenuItemButton {
   }
 }
 
-class CopyChannelLinkButton extends ActionSheetMenuItemButton {
+class CopyChannelLinkButton extends ContextMenuItemButton {
   const CopyChannelLinkButton({
     super.key,
     required this.channelId,
@@ -350,7 +354,7 @@ void showTopicActionSheet(BuildContext context, {
   final store = PerAccountStoreWidget.of(pageContext);
   final subscription = store.subscriptions[channelId];
 
-  final optionButtons = <ActionSheetMenuItemButton>[];
+  final buttons = <ContextMenuItemButton>[];
 
   // TODO(server-7): simplify this condition away
   final supportsUnmutingTopics = store.zulipFeatureLevel >= 170;
@@ -412,7 +416,7 @@ void showTopicActionSheet(BuildContext context, {
       }
     }
   }
-  optionButtons.addAll(visibilityOptions.map((to) {
+  buttons.addAll(visibilityOptions.map((to) {
     return UserTopicUpdateButton(
       currentVisibilityPolicy: visibilityPolicy,
       newVisibilityPolicy: to,
@@ -423,27 +427,27 @@ void showTopicActionSheet(BuildContext context, {
   // TODO: check for other cases that may disallow this action (e.g.: time
   //   limit for editing topics).
   if (someMessageIdInTopic != null && topic.displayName != null) {
-    optionButtons.add(ResolveUnresolveButton(pageContext: pageContext,
+    buttons.add(ResolveUnresolveButton(pageContext: pageContext,
       topic: topic,
       someMessageIdInTopic: someMessageIdInTopic));
   }
 
   final unreadCount = store.unreads.countInTopicNarrow(channelId, topic);
   if (unreadCount > 0) {
-    optionButtons.add(MarkTopicAsReadButton(
+    buttons.add(MarkTopicAsReadButton(
       channelId: channelId,
       topic: topic,
       pageContext: context));
   }
 
-  optionButtons.add(CopyTopicLinkButton(
+  buttons.add(CopyTopicLinkButton(
     narrow: TopicNarrow(channelId, topic, with_: someMessageIdInTopic),
     pageContext: context));
 
-  _showActionSheet(pageContext, optionButtons: optionButtons);
+  _showContextMenu(pageContext, buttons: buttons);
 }
 
-class UserTopicUpdateButton extends ActionSheetMenuItemButton {
+class UserTopicUpdateButton extends ContextMenuItemButton {
   const UserTopicUpdateButton({
     super.key,
     required this.currentVisibilityPolicy,
@@ -562,7 +566,7 @@ class UserTopicUpdateButton extends ActionSheetMenuItemButton {
   }
 }
 
-class ResolveUnresolveButton extends ActionSheetMenuItemButton {
+class ResolveUnresolveButton extends ContextMenuItemButton {
   ResolveUnresolveButton({
     super.key,
     required this.topic,
@@ -573,14 +577,14 @@ class ResolveUnresolveButton extends ActionSheetMenuItemButton {
   /// The topic that the action sheet was opened for.
   ///
   /// There might not currently be any messages with this topic;
-  /// see dartdoc of [ActionSheetMenuItemButton].
+  /// see dartdoc of [ContextMenuItemButton].
   final TopicName topic;
 
   /// The message ID that was passed when opening the action sheet.
   ///
   /// The message with this ID might currently not exist,
   /// or might exist with a different topic;
-  /// see dartdoc of [ActionSheetMenuItemButton].
+  /// see dartdoc of [ContextMenuItemButton].
   final int someMessageIdInTopic;
 
   final bool _actionIsResolve;
@@ -636,7 +640,7 @@ class ResolveUnresolveButton extends ActionSheetMenuItemButton {
   }
 }
 
-class MarkTopicAsReadButton extends ActionSheetMenuItemButton {
+class MarkTopicAsReadButton extends ContextMenuItemButton {
   const MarkTopicAsReadButton({
     super.key,
     required this.channelId,
@@ -659,7 +663,7 @@ class MarkTopicAsReadButton extends ActionSheetMenuItemButton {
   }
 }
 
-class CopyTopicLinkButton extends ActionSheetMenuItemButton {
+class CopyTopicLinkButton extends ContextMenuItemButton {
   const CopyTopicLinkButton({
     super.key,
     required this.narrow,
@@ -711,7 +715,7 @@ void showMessageActionSheet({required BuildContext context, required Message mes
 
   final isSenderMuted = store.isUserMuted(message.senderId);
 
-  final optionButtons = [
+  final buttons = [
     if (popularEmojiLoaded)
       ReactionButtons(message: message, pageContext: pageContext),
     if (hasReactions)
@@ -731,8 +735,8 @@ void showMessageActionSheet({required BuildContext context, required Message mes
       EditButton(message: message, pageContext: pageContext),
   ];
 
-  _showActionSheet(pageContext,
-    optionButtons: optionButtons,
+  _showContextMenu(pageContext,
+    buttons: buttons,
     header: _MessageActionSheetHeader(message: message));
 }
 
@@ -769,7 +773,7 @@ class _MessageActionSheetHeader extends StatelessWidget {
   }
 }
 
-abstract class MessageActionSheetMenuItemButton extends ActionSheetMenuItemButton {
+abstract class MessageActionSheetMenuItemButton extends ContextMenuItemButton {
   MessageActionSheetMenuItemButton({
     super.key,
     required this.message,

lib/widgets/emoji_reaction.dart

@@ -822,7 +822,7 @@ class ViewReactionsHeader extends StatelessWidget {
     if (reactions == null || reactions.aggregated.isEmpty) {
       return Padding(
         padding: const EdgeInsets.only(top: 8),
-        child: BottomSheetHeaderPlainText(text: zulipLocalizations.seeWhoReactedSheetNoReactions),
+        child: ContextMenuHeaderPlainText(text: zulipLocalizations.seeWhoReactedSheetNoReactions),
       );
     }