actions_test [nfc]: Use updateMessageFlagsStartingFromAnchor in it's cases

Author: Khader-1

test/widgets/actions_test.dart

@@ -240,14 +240,17 @@ void main() {
       // Check that `lastProcessedId` returned from an initial
       // response is used as `anchorId` for the subsequent request.
       final narrow = TopicNarrow.ofMessage(eg.streamMessage());
+      final apiNarrow = narrow.apiEncode()..add(ApiNarrowIsUnread());
       await prepare(tester);
 
       connection.prepare(json: UpdateMessageFlagsForNarrowResult(
         processedCount: 1000, updatedCount: 890,
         firstProcessedId: 1, lastProcessedId: 1989,
         foundOldest: true, foundNewest: false).toJson());
-      markNarrowAsRead(context, narrow);
-      final apiNarrow = narrow.apiEncode()..add(ApiNarrowIsUnread());
+      final didPass = updateMessageFlagsStartingFromAnchor(
+        context: context, apiNarrow: apiNarrow, op: UpdateMessageFlagsOp.add, flag: MessageFlag.read,
+        includeAnchor: false, startingAnchor: AnchorCode.oldest, onCompletedMessage: onCompletedMessage,
+        onFailedTitle: onFailedTitle, progressMessage: progressMessage);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
         ..url.path.equals('/api/v1/messages/flags/narrow')
@@ -279,19 +282,23 @@ void main() {
             'op': 'add',
             'flag': 'read',
           });
+      check(await didPass).isTrue();
     });
 
     testWidgets('on invalid response', (WidgetTester tester) async {
       final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
       final narrow = TopicNarrow.ofMessage(eg.streamMessage());
+      final apiNarrow = narrow.apiEncode()..add(ApiNarrowIsUnread());
       await prepare(tester);
       connection.prepare(json: UpdateMessageFlagsForNarrowResult(
         processedCount: 1000, updatedCount: 0,
         firstProcessedId: null, lastProcessedId: null,
         foundOldest: true, foundNewest: false).toJson());
-      markNarrowAsRead(context, narrow);
+      final didPass = updateMessageFlagsStartingFromAnchor(
+        context: context, apiNarrow: apiNarrow, op: UpdateMessageFlagsOp.add, flag: MessageFlag.read,
+        includeAnchor: false, startingAnchor: AnchorCode.oldest, onCompletedMessage: onCompletedMessage,
+        onFailedTitle: onFailedTitle, progressMessage: progressMessage);
       await tester.pump(Duration.zero);
-      final apiNarrow = narrow.apiEncode()..add(ApiNarrowIsUnread());
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
         ..url.path.equals('/api/v1/messages/flags/narrow')
@@ -307,21 +314,26 @@ void main() {
 
       await tester.pumpAndSettle();
       checkErrorDialog(tester,
-        expectedTitle: zulipLocalizations.errorMarkAsReadFailedTitle,
+        expectedTitle: onFailedTitle,
         expectedMessage: zulipLocalizations.errorInvalidResponse);
+      check(await didPass).isFalse();
     });
 
     testWidgets('catch-all api errors', (WidgetTester tester) async {
-      final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
       const narrow = CombinedFeedNarrow();
+      final apiNarrow = narrow.apiEncode()..add(ApiNarrowIsUnread());
       await prepare(tester);
       connection.prepare(exception: http.ClientException('Oops'));
-      markNarrowAsRead(context, narrow);
+      final didPass = updateMessageFlagsStartingFromAnchor(
+        context: context, apiNarrow: apiNarrow, op: UpdateMessageFlagsOp.add, flag: MessageFlag.read,
+        includeAnchor: false, startingAnchor: AnchorCode.oldest, onCompletedMessage: onCompletedMessage,
+        onFailedTitle: onFailedTitle, progressMessage: progressMessage);
       await tester.pump(Duration.zero);
       await tester.pumpAndSettle();
       checkErrorDialog(tester,
-        expectedTitle: zulipLocalizations.errorMarkAsReadFailedTitle,
+        expectedTitle: onFailedTitle,
         expectedMessage: 'NetworkException: Oops (ClientException: Oops)');
+      check(await didPass).isFalse();
     });
   });
 }