Skip to content

Commit 49a1a4e

Browse files
committed
autocomplete [nfc]: Fill in some TODO(#...) issue numbers
1 parent 234b65d commit 49a1a4e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/model/autocomplete.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ class MentionAutocompleteView extends ChangeNotifier {
267267
}
268268
}
269269
}
270-
return results; // TODO sort for most relevant first
270+
return results; // TODO(#228) sort for most relevant first
271271
}
272272
}
273273

@@ -283,8 +283,8 @@ class MentionAutocompleteQuery {
283283
final List<String> _lowercaseWords;
284284

285285
bool testUser(User user, AutocompleteDataCache cache) {
286-
// TODO test email too, not just name
287-
// TODO test with diacritics stripped, where appropriate
286+
// TODO(#236) test email too, not just name
287+
// TODO(#237) test with diacritics stripped, where appropriate
288288

289289
final List<String> nameWords = cache.nameWordsForUser(user);
290290

lib/widgets/autocomplete.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ class _ComposeAutocompleteState extends State<ComposeAutocomplete> {
9292
// (maybe handle centrally in `widget.controller`)
9393
replacementString = '${mention(store.users[userId]!, silent: intent.query.silent, users: store.users)} ';
9494
case WildcardMentionAutocompleteResult():
95-
replacementString = '[unimplemented]'; // TODO
95+
replacementString = '[unimplemented]'; // TODO(#234)
9696
case UserGroupMentionAutocompleteResult():
97-
replacementString = '[unimplemented]'; // TODO
97+
replacementString = '[unimplemented]'; // TODO(#233)
9898
}
9999

100100
widget.controller.value = intent.textEditingValue.replaced(
@@ -110,12 +110,12 @@ class _ComposeAutocompleteState extends State<ComposeAutocomplete> {
110110
String label;
111111
switch (option) {
112112
case UserMentionAutocompleteResult(:var userId):
113-
// TODO avatar
113+
// TODO(#227) avatar
114114
label = PerAccountStoreWidget.of(context).users[userId]!.fullName;
115115
case WildcardMentionAutocompleteResult():
116-
label = '[unimplemented]'; // TODO
116+
label = '[unimplemented]'; // TODO(#234)
117117
case UserGroupMentionAutocompleteResult():
118-
label = '[unimplemented]'; // TODO
118+
label = '[unimplemented]'; // TODO(#233)
119119
}
120120
return InkWell(
121121
onTap: () {

0 commit comments

Comments
 (0)