Skip to content

Commit 14520bc

Browse files
committed
lightbox test [nfc]: Note a previous draft for some TODO-requested tests
I've had a tab in my browser open to the end of this #833 thread. Here seems like the right place to serialize out that information so that I can close the tab.
1 parent 5d36977 commit 14520bc

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

test/widgets/lightbox_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,13 @@ void main() {
280280
// TODO test image is scaled down to fit, but not up
281281
// TODO test image doesn't change size when header and footer hidden/shown
282282
// TODO test image doesn't show in inset area by default, but does if user zooms/pans it there
283+
//
284+
// A draft version of some of those desired tests:
285+
// https://github.com/zulip/zulip-flutter/commit/ec4078d459da749f16511b826c5f7c398b0fb874
286+
// Discussion related to that draft:
287+
// https://github.com/zulip/zulip-flutter/pull/833#discussion_r1688762292
288+
// https://github.com/zulip/zulip-flutter/pull/833#pullrequestreview-2200433626
289+
// https://github.com/zulip/zulip-flutter/pull/833#issuecomment-2251782337
283290
});
284291

285292
group('VideoDurationLabel', () {

0 commit comments

Comments
 (0)