Skip to content

Commit 1381f5e

Browse files
committed
lightbox [nfc]: Add issue numbers to plain TODOs
I've just filed these, after the lightbox prototype was merged. They're not all high-priority issues.
1 parent d3a3178 commit 1381f5e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

lib/widgets/lightbox.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'page.dart';
88
import 'clipboard.dart';
99
import 'store.dart';
1010

11-
// TODO: Add index of the image preview in the message, to not break if
11+
// TODO(#44): Add index of the image preview in the message, to not break if
1212
// there are multiple image previews with the same URL in the same
1313
// message. Maybe keep `src`, so that on exit the lightbox image doesn't
1414
// fly to an image preview with a different URL, following a message edit
@@ -98,7 +98,7 @@ class _LightboxPage extends StatefulWidget {
9898
}
9999

100100
class _LightboxPageState extends State<_LightboxPage> {
101-
// TODO: Animate entrance/exit of header and footer
101+
// TODO(#38): Animate entrance/exit of header and footer
102102
bool _headerFooterVisible = false;
103103

104104
@override
@@ -135,7 +135,7 @@ class _LightboxPageState extends State<_LightboxPage> {
135135

136136
PreferredSizeWidget? appBar;
137137
if (_headerFooterVisible) {
138-
// TODO: Format with e.g. "Yesterday at 4:47 PM"
138+
// TODO(#45): Format with e.g. "Yesterday at 4:47 PM"
139139
final timestampText = DateFormat
140140
.yMMMd(/* TODO(i18n): Pass selected language here, I think? */)
141141
.add_Hms()
@@ -146,7 +146,7 @@ class _LightboxPageState extends State<_LightboxPage> {
146146
foregroundColor: appBarForegroundColor,
147147
backgroundColor: appBarBackgroundColor,
148148

149-
// TODO: Show message author's avatar
149+
// TODO(#41): Show message author's avatar
150150
title: RichText(
151151
text: TextSpan(
152152
children: [
@@ -170,8 +170,8 @@ class _LightboxPageState extends State<_LightboxPage> {
170170
child: Row(
171171
children: [
172172
_CopyLinkButton(url: widget.src),
173-
// TODO: Share image
174-
// TODO: Download image
173+
// TODO(#43): Share image
174+
// TODO(#42): Download image
175175
]));
176176
}
177177

@@ -218,7 +218,7 @@ Route getLightboxRoute({
218218
Animation<double> animation,
219219
Animation<double> secondaryAnimation,
220220
) {
221-
// TODO: Drag down to close?
221+
// TODO(#40): Drag down to close?
222222
return _LightboxPage(routeEntranceAnimation: animation, message: message, src: src);
223223
},
224224
transitionsBuilder: (

0 commit comments

Comments
 (0)