Stricter domain name pattern in email regex (go-gitea#6768)

mrsdizzie · lafriks · commit 8b3aad940e91 · 2019-04-26T18:40:22.000+03:00
Backport of go-gitea#6739
diff --git a/modules/markup/html.go b/modules/markup/html.go
@@ -63,7 +63,7 @@ var (
 	// well as the HTML5 spec:
 	//   http://spec.commonmark.org/0.28/#email-address
 	//   https://html.spec.whatwg.org/multipage/input.html#e-mail-state-(type%3Demail)
-	emailRegex = regexp.MustCompile("[a-zA-Z0-9.!#$%&'*+\\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*")
+	emailRegex = regexp.MustCompile("[a-zA-Z0-9.!#$%&'*+\\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9]{2,}(?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)+")
 
 	linkRegex, _ = xurls.StrictMatchingScheme("https?://")
 )

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ var (`
`63`	`63`	`// well as the HTML5 spec:`
`64`	`64`	`// http://spec.commonmark.org/0.28/#email-address`
`65`	`65`	`// https://html.spec.whatwg.org/multipage/input.html#e-mail-state-(type%3Demail)`
`66`		- emailRegex = regexp.MustCompile("[a-zA-Z0-9.!#$%&'+\\/=?^_`{\|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)")
	`66`	+ emailRegex = regexp.MustCompile("[a-zA-Z0-9.!#$%&'*+\\/=?^_`{\|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9]{2,}(?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)+")
`67`	`67`
`68`	`68`	`linkRegex, _ = xurls.StrictMatchingScheme("https?://")`
`69`	`69`	`)`