Ignore review comment when ref commit is missed (go-gitea#16905) (go-gitea#16919)

lunny · web-flow · commit 8b132bdec622 · 2021-09-02T11:51:32.000+01:00
backport go-gitea#16905
diff --git a/modules/migrations/gitea_uploader.go b/modules/migrations/gitea_uploader.go
@@ -808,7 +808,8 @@ func (g *GiteaLocalUploader) CreateReviews(reviews ...*base.Review) error {
 			}
 			headCommitID, err := g.gitRepo.GetRefCommitID(pr.GetGitRefName())
 			if err != nil {
-				return fmt.Errorf("GetRefCommitID[%s]: %v", pr.GetGitRefName(), err)
+				log.Warn("GetRefCommitID[%s]: %v, the review comment will be ignored", pr.GetGitRefName(), err)
+				continue
 			}
 
 			var patch string

Original file line number	Diff line number	Diff line change
`@@ -808,7 +808,8 @@ func (g GiteaLocalUploader) CreateReviews(reviews ...base.Review) error {`
`808`	`808`	`}`
`809`	`809`	`headCommitID, err := g.gitRepo.GetRefCommitID(pr.GetGitRefName())`
`810`	`810`	`if err != nil {`
`811`		`- return fmt.Errorf("GetRefCommitID[%s]: %v", pr.GetGitRefName(), err)`
	`811`	`+ log.Warn("GetRefCommitID[%s]: %v, the review comment will be ignored", pr.GetGitRefName(), err)`
	`812`	`+ continue`
`812`	`813`	`}`
`813`	`814`
`814`	`815`	`var patch string`