Prevent NPE on partial match of compare URL (part 2) (go-gitea#18490)

Backport go-gitea#18490

Unfortunately go-gitea#18472 only fixed part of the ways a nil pointer can occur in the
compare url. We also need to ensure that the match array has all the matches present.

Fix go-gitea#18471
Related go-gitea#18472

Signed-off-by: Andrew Thornton <[email protected]>

Author: zeripath

modules/markup/html.go

@@ -945,6 +945,9 @@ func comparePatternProcessor(ctx *RenderContext, node *html.Node) {
 		}
 
 		// Ensure that every group (m[0]...m[7]) has a match
+		if len(m) < 8 {
+			return
+		}
 		for i := 0; i < 8; i++ {
 			if m[i] == -1 {
 				return
@@ -957,7 +960,7 @@ func comparePatternProcessor(ctx *RenderContext, node *html.Node) {
 		text2 := base.ShortSha(node.Data[m[6]:m[7]])
 
 		hash := ""
-		if m[9] > 0 {
+		if len(m) > 9 && m[9] > 0 {
 			hash = node.Data[m[8]:m[9]][1:]
 		}