doc: getting_started: Modernize macOS instructions #6949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernize macOS instructions to fit the latest packages offered by Homebrew and macOS High Sierra. Signed-off-by: Carles Cufi <[email protected]>
|
hmm #6934? |
|
@nashif oh sorry, I didn't realize. Can you take my changes, or do you want me to take yours? |
Codecov Report
@@ Coverage Diff @@
## master #6949 +/- ##
==========================================
+ Coverage 55.63% 55.63% +<.01%
==========================================
Files 462 462
Lines 44568 44568
Branches 8296 8296
==========================================
+ Hits 24795 24796 +1
+ Misses 16381 16380 -1
Partials 3392 3392
Continue to review full report at Codecov.
|
i was first :) |
andrewboie
approved these changes
Apr 5, 2018
|
@nashif ok! let's merge your PR and then I will rebase mine :) |
|
no i am fine with this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize macOS instructions to fit the latest packages offered by
Homebrew and macOS High Sierra.
Signed-off-by: Carles Cufi [email protected]