Disallow untyped calls

Author: dstansby

pyproject.toml

@@ -166,6 +166,8 @@ check_untyped_defs = true
 disallow_untyped_decorators = true
 disallow_any_generics = true
 
+disallow_untyped_calls = true
+
 [[tool.mypy.overrides]]
 module = [
     "zarr.v2.*",
@@ -188,6 +190,19 @@ module = [
 ]
 disallow_any_generics = false
 
+[[tool.mypy.overrides]]
+module = [
+    "zarr.v2.*",
+    "zarr.array_v2",
+    "zarr.array",
+    "zarr.common",
+    "zarr.store.local",
+    "zarr.codecs.blosc",
+    "zarr.codecs.gzip",
+    "zarr.codecs.zstd",
+]
+disallow_untyped_calls = false
+
 
 [tool.pytest.ini_options]
 doctest_optionflags = [

src/zarr/common.py

@@ -79,7 +79,7 @@ class ArraySpec:
     dtype: np.dtype[Any]
     fill_value: Any
 
-    def __init__(self, shape, dtype, fill_value):
+    def __init__(self, shape: ChunkCoords, dtype: np.dtype[Any], fill_value: Any) -> None:
         shape_parsed = parse_shapelike(shape)
         dtype_parsed = parse_dtype(dtype)
         fill_value_parsed = parse_fill_value(fill_value)

src/zarr/indexing.py

@@ -19,7 +19,7 @@ def _err_too_many_indices(selection: SliceSelection, shape: ChunkCoords):
     )
 
 
-def _err_negative_step():
+def _err_negative_step() -> None:
     raise IndexError("only slices with step >= 1 are supported")
 
 
@@ -50,7 +50,7 @@ class _ChunkDimProjection(NamedTuple):
     dim_out_sel: Optional[slice]
 
 
-def _ceildiv(a, b):
+def _ceildiv(a, b) -> int:
     return math.ceil(a / b)
 
 

src/zarr/sync.py

@@ -80,7 +80,7 @@ def sync(coro: Coroutine, loop: Optional[asyncio.AbstractEventLoop] = None):
         return return_result
 
 
-def _get_loop():
+def _get_loop() -> asyncio.AbstractEventLoop:
     """Create or return the default fsspec IO loop
 
     The loop will be running on a separate thread.
@@ -96,7 +96,10 @@ def _get_loop():
                 th.daemon = True
                 th.start()
                 iothread[0] = th
-    return loop[0]
+
+        return new_loop
+    else:
+        return loop[0]
 
 
 P = ParamSpec("P")