-
Notifications
You must be signed in to change notification settings - Fork 98
Add entrypoints to setup.py #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8f78908
Add entrypoints to setup.py
joshmoore 55ba58b
Check syspath and ignore error
joshmoore 7b39923
Temporarily disable codec test on Windows
joshmoore 93dab7a
Try adding entry test to manifest
joshmoore 1f01895
Merge branch 'main' into entrypoints-req
jakirkham 497b4db
Add `entrypoints` to `requirements.txt`
jakirkham 6d2399c
Add `entrypoints` to `requirements_dev.txt`
jakirkham 51f5796
Remove `entrypoints` from `requirements_test.txt`
jakirkham 688dbf0
Add `entrypoints` to `requirements_rtfd.txt`
jakirkham 8857295
Note `numcodecs` is not `zip_safe`
jakirkham 01e19e7
xfail the test completely
joshmoore c1d4b4d
Merge branch 'main' into entrypoints-req
jakirkham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
cython | ||
entrypoints | ||
numpy | ||
msgpack | ||
pytest | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
Cython==0.29.21 | ||
entrypoints==0.4 | ||
msgpack==1.0.2 | ||
numpy==1.22.0 | ||
zfpy==0.5.5 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,5 +6,6 @@ numpydoc | |
mock | ||
numpy | ||
cython | ||
entrypoints | ||
zfpy==0.5.5 | ||
typing-extensions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
coverage | ||
coveralls | ||
entrypoints | ||
flake8 | ||
pytest | ||
pytest-cov | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -337,6 +337,7 @@ def run_setup(with_extensions): | |
'setuptools-scm>1.5.4' | ||
], | ||
install_requires=[ | ||
'entrypoints', | ||
'numpy>=1.7', | ||
'typing-extensions>=3.7.4', | ||
], | ||
|
@@ -369,6 +370,7 @@ def run_setup(with_extensions): | |
maintainer_email='[email protected]', | ||
url='https://github.com/zarr-developers/numcodecs', | ||
license='MIT', | ||
zip_safe=False, | ||
) | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be needed. Just trying something 🍀
That said, we probably already should have had this given we have shared libraries
Or at least shared libraries misbehaving was what had usually prompted this before. Maybe it is not as relevant anymore