Skip to content

Remove the check if there are mapping aware services defined #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

jurgenf
Copy link
Contributor

@jurgenf jurgenf commented Oct 22, 2020

Remove the check if there are mapping aware services defined as the resolver argument still needs to be set on line 169 if no mapping aware services are defined.

…esolver argument still needs to be set on line 169 if no mapping aware services are defined.
@jurgenf jurgenf requested a review from yoanm as a code owner October 22, 2020 11:35
yoanm added a commit that referenced this pull request Oct 23, 2020
@yoanm yoanm changed the base branch from master to hotfix/3.0.3 October 23, 2020 06:56
Copy link
Owner

@yoanm yoanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yoanm
Copy link
Owner

yoanm commented Oct 23, 2020

Hello,

Thanks for your contribution 👌.
I updated FTs to have one bundle config without MappingCollector in order to cover that case (#67).

I just wait CI, then I'll merge your PR, then mine for the FT and will create a new release

@yoanm yoanm merged commit 3fe52a6 into yoanm:hotfix/3.0.3 Oct 23, 2020
@yoanm yoanm mentioned this pull request Oct 23, 2020
yoanm added a commit that referenced this pull request Oct 23, 2020
@yoanm
Copy link
Owner

yoanm commented Oct 23, 2020

v3.0.3 ready !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants