Skip to content

#81: add JsonRpcResponseNormalizer::$debug #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 8, 2023

Conversation

klimov-paul
Copy link
Contributor

Add JsonRpcResponseNormalizer::$debug allowing rendering error trace if enabled trace if enabled.

Fixes #81

  • Tests pass.
  • BC seems to be kept. as only constructor signatures have been modified and only with optional arguments.

Copy link
Owner

@yoanm yoanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, else nice work 👌

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #82 (20b4111) into master (0cf5486) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master       #82   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       145       170   +25     
===========================================
  Files             27        28    +1     
  Lines            389       454   +65     
===========================================
+ Hits             389       454   +65     
Flag Coverage Δ
functional-tests 99.55% <100.00%> (+0.07%) ⬆️
php-8.2 100.00% <100.00%> (ø)
unit-tests 19.82% <0.00%> (-3.32%) ⬇️
Impacted Files Coverage Δ
...p/Serialization/JsonRpcResponseErrorNormalizer.php 100.00% <100.00%> (ø)
...rc/App/Serialization/JsonRpcResponseNormalizer.php 100.00% <100.00%> (ø)
src/Domain/Exception/JsonRpcException.php 100.00% <100.00%> (ø)
...Domain/Exception/JsonRpcInternalErrorException.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yoanm
Copy link
Owner

yoanm commented Apr 8, 2023

Humm, something wrong with the coverage, I do see it at 100% locally 🤔
I'll try to figure out what happens

@yoanm yoanm force-pushed the 81-internal-server-error branch from a73faf9 to e31aae0 Compare April 8, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent PHP exception procesing
2 participants