chore(core): use const for pkg variable in getCandidates (#4161)

* refactor(core): use const for pkg variable in getCandidates

* chore: yarn version check --interactive

Author: trivikr

.yarn/versions/fb518f4e.yml

@@ -0,0 +1,33 @@
+releases:
+  "@yarnpkg/core": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/cli"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

packages/yarnpkg-core/sources/LockfileResolver.ts

@@ -42,19 +42,19 @@ export class LockfileResolver implements Resolver {
   }
 
   async getCandidates(descriptor: Descriptor, dependencies: unknown, opts: ResolveOptions) {
-    let pkg = opts.project.originalPackages.get(structUtils.convertDescriptorToLocator(descriptor).locatorHash);
-    if (pkg)
-      return [pkg];
+    const originalPkg = opts.project.originalPackages.get(structUtils.convertDescriptorToLocator(descriptor).locatorHash);
+    if (originalPkg)
+      return [originalPkg];
 
     const resolution = opts.project.storedResolutions.get(descriptor.descriptorHash);
     if (!resolution)
       throw new Error(`Expected the resolution to have been successful - resolution not found`);
 
-    pkg = opts.project.originalPackages.get(resolution);
-    if (!pkg)
+    const resolvedPkg = opts.project.originalPackages.get(resolution);
+    if (!resolvedPkg)
       throw new Error(`Expected the resolution to have been successful - package not found`);
 
-    return [pkg];
+    return [resolvedPkg];
   }
 
   async getSatisfying(descriptor: Descriptor, references: Array<string>, opts: ResolveOptions) {