Skip to content

Commit 54317ad

Browse files
authored
build(pnp): use rollup to bundle the library (#3931)
* build(pnp): use rollup to bundle the library * chore: remove unnecessary `typescript` peer dependency * chore: change references to `webpack` to `rollup` and `esbuild` * docs: remove outdated Babel comment * chore: update gitignore * chore: remove unnecessary `typescript` dependencies * ci: remove leftover build monitoring
1 parent 99b807c commit 54317ad

File tree

66 files changed

+615
-2454
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+615
-2454
lines changed

β€Ž.github/workflows/integration-workflow.ymlβ€Ž

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ jobs:
153153

154154
- name: 'Build bundle & plugins'
155155
run: |
156-
export BUILD_MONITORING_ENABLED=1
157156
node --version
158157
node ./scripts/run-yarn.js build:pnp:hook
159158
node ./scripts/run-yarn.js build:cli
@@ -167,8 +166,6 @@ jobs:
167166
node ./scripts/run-yarn.js build:plugin-version
168167
node ./scripts/run-yarn.js build:plugin-workspace-tools
169168
shell: bash
170-
env:
171-
DD_API_KEY: ${{ secrets.DD_API_KEY }}
172169

173170
- uses: actions/upload-artifact@v2
174171
with:

β€Ž.github/workflows/pr-smart-merge.ymlβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ jobs:
4545
4646
if git diff --name-only --diff-filter=U | grep packages/yarnpkg-pnp/sources/hook.js; then
4747
git checkout --theirs packages/yarnpkg-pnp/sources/hook.js
48-
yarn build:pnp:cjs
48+
yarn build:pnp:hook
4949
SHOULD_RUN_AN_INSTALL=1
5050
fi
5151
5252
if git diff --name-only --diff-filter=U | grep packages/yarnpkg-pnp/sources/esm-loader/built-loader.js; then
5353
git checkout --theirs packages/yarnpkg-pnp/sources/esm-loader/built-loader.js
54-
yarn build:pnp:esm
54+
yarn build:pnp:hook
5555
SHOULD_RUN_AN_INSTALL=1
5656
fi
5757

β€Ž.gitignoreβ€Ž

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ package.tgz
3434
# Those packages are built inline and the JS files must not be checked-in
3535
/packages/yarnpkg-libui/sources/**/*.js
3636

37-
# We check-in the PnP hook because it would be heavy to regenerate it before each bundle build
38-
!/packages/yarnpkg-pnp/lib/hook.js
39-
4037
/vscode-case-study
4138

4239
.idea

β€Ž.pnp.cjsβ€Ž

Lines changed: 510 additions & 1713 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
Β (0)