fix: unknown-options-as-args should treat negated boolean as unknown when boolean-negation:false

Author: shadowspawn

lib/yargs-parser.ts

@@ -987,7 +987,10 @@ export class YargsParser {
       // e.g. '-a/usr/local'
       const flagEndingInNonWordCharacters = /^-+([^=]+?)\W+.*$/
       // check the different types of flag styles, including negatedBoolean, a pattern defined near the start of the parse method
-      return !hasFlagsMatching(arg, flagWithEquals, negatedBoolean, normalFlag, flagEndingInHyphen, flagEndingInDigits, flagEndingInNonWordCharacters)
+      const patterns = [flagWithEquals, normalFlag, flagEndingInHyphen, flagEndingInDigits, flagEndingInNonWordCharacters];
+      if (configuration['boolean-negation'])
+        patterns.push(negatedBoolean);
+      return !hasFlagsMatching(arg, ...patterns)
     }
 
     // make a best effort to pick a default value

test/yargs-parser.mjs

@@ -3053,6 +3053,18 @@ describe('yargs-parser', function () {
           knownArg: false
         })
       })
+      it('should ignore negated known options when boolean-negation:false', function () {
+        const argv = parser('--no-known-arg --no-unknown-arg', {
+          boolean: ['known-arg'],
+          configuration: {
+            'unknown-options-as-args': true,
+            'boolean-negation': false
+          }
+        })
+        argv.should.deep.equal({
+          _: ['--no-known-arg', '--no-unknown-arg']
+        })
+      })
       it('should ignore unknown options in long format separated by space', function () {
         const argv = parser('--known-arg a --unknown-arg b', {
           string: ['known-arg'],