Add full example in react/jsx-no-target-blank #1988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Sep 19, 2018
docs/rules/jsx-no-target-blank.md
Outdated
| * `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link | ||
|
|
||
| ```json | ||
| "react/jsx-no-target-blank": [<enabled>, { enforceDynamicLinks: <enforce> }] |
Member
There was a problem hiding this comment.
the key needs to be quoted, since it's json
docs/rules/jsx-no-target-blank.md
Outdated
| ``` | ||
|
|
||
| * enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0. | ||
| * enforce: optional string, defaults to "always" |
Member
There was a problem hiding this comment.
this seems redundant, since it's on lines 18-19
Contributor
Author
There was a problem hiding this comment.
Again, I'm following how it works on some other pages
Contributor
Author
|
Made that change. I looked at some of the other docs more carefully, and reordered the Rule Options so hopefully it makes a bit more sense. |
ljharb
approved these changes
Sep 20, 2018
1 task
1 task
This was referenced Dec 28, 2018
Closed
This was referenced Jan 8, 2019
ghost
mentioned this pull request
This was referenced Jan 13, 2019
Merged
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1986
I found the docs a bit unclear, so I've added a fuller example, hopefully in line with other examples.