Skip to content

fix: stubs #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix: stubs #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
912841f
fix: html stub
yajra Feb 26, 2025
beb6fb6
ci: duplicate analysis on push
yajra Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: "Static Analysis"

on:
push:
branches:
- master
- 11.x
paths:
- .github/workflows/static-analysis.yml
- composer.*
Expand Down
1 change: 0 additions & 1 deletion src/Generators/stubs/datatables.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class DummyClass extends DataTable
->setTableId('DummyTableId')
->columns($this->getColumns())
->minifiedAjax()
//->dom('DummyDOM')
->orderBy(1)
->selectStyleSingle()
->buttons([
Expand Down
19 changes: 10 additions & 9 deletions src/Generators/stubs/html.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace DummyNamespace;

use Yajra\DataTables\Html\Builder;
use Yajra\DataTables\Html\Button;
use Yajra\DataTables\Html\Column;
use Yajra\DataTables\Html\DataTableHtml;
Expand All @@ -17,15 +18,15 @@ class DummyClass extends DataTableHtml
*/
public function handle(): Builder
{
return $this->setTableId('DummyTableId')
->columns($this->getColumns())
->minifiedAjax()
//->dom('DummyDOM')
->orderBy(1)
->selectStyleSingle()
->buttons([
DummyButtons
]);
return $this->getHtmlBuilder()
->setTableId('DummyTableId')
->columns($this->getColumns())
->minifiedAjax()
->orderBy(1)
->selectStyleSingle()
->buttons([
DummyButtons
]);
}

/**
Expand Down