Skip to content

Commit f270b39

Browse files
committed
Apply code review comments
1 parent 5d8cd33 commit f270b39

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

tests/test_handlers.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,7 @@ def setUp(self) -> None:
772772
class ExpectedLogEvent:
773773
"""
774774
Simple class to represent an expected log event, which contains all relevant
775-
log event metadata and user-generated kv pairs.
775+
log event metadata and user-generated kv-pairs.
776776
"""
777777

778778
def __init__(
@@ -796,7 +796,7 @@ class TestClpKeyValuePairLoggingBase(unittest.TestCase):
796796
"""
797797
A base class for testing CLP key-value pair handlers.
798798
799-
TODO: Functionality wise this class is mirroring `TestCLPBase`. We should refactor `TestCLPBase`
799+
TODO: Functionality-wise, this class mirrors `TestCLPBase`. We should refactor `TestCLPBase`
800800
to support both raw-text logging (unstructured logging) and key-value pair logging (structured
801801
logging).
802802
"""
@@ -819,8 +819,8 @@ def setUpClass(cls) -> None:
819819

820820
# override
821821
def setUp(self) -> None:
822-
post_fix: str = ".clp.zst" if self._enable_compression else ".clp"
823-
self._clp_log_path: Path = LOG_DIR / Path(f"{self.id()}{post_fix}")
822+
file_extension: str = ".clp.zst" if self._enable_compression else ".clp"
823+
self._clp_log_path: Path = LOG_DIR / Path(f"{self.id()}{file_extension}")
824824
if self._clp_log_path.exists():
825825
self._clp_log_path.unlink()
826826
self._logger: logging.Logger = logging.getLogger(self.id())
@@ -877,7 +877,6 @@ def _compare(self) -> None:
877877
auto_generated_kv_pairs[LEVEL_KEY][LEVEL_NAME_KEY], expected.level_name
878878
)
879879

880-
# Check the path by converting the path string to `Path` object
881880
self.assertEqual(
882881
Path(auto_generated_kv_pairs[SOURCE_CONTEXT_KEY][SOURCE_CONTEXT_PATH_KEY]),
883882
expected.path,

0 commit comments

Comments
 (0)