Skip to content

Commit d89b287

Browse files
mgoinxuebwang-amd
authored andcommitted
[CI Bugfix] Fix failing test_model_load_with_params tests due to tokenizer refactor (vllm-project#25086)
Signed-off-by: mgoin <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
1 parent 840dc39 commit d89b287

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tests/model_executor/test_model_load_with_params.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ def test_model_loading_with_params(vllm_runner, monkeypatch):
4747
assert model_config.pooler_config.normalize
4848

4949
# asserts on the tokenizer loaded
50-
assert model_tokenizer.tokenizer_id == "BAAI/bge-base-en-v1.5"
51-
assert model_tokenizer.tokenizer.model_max_length == 512
50+
assert model_config.tokenizer == "BAAI/bge-base-en-v1.5"
51+
assert model_tokenizer.model_max_length == 512
5252

5353
def check_model(model):
5454
assert isinstance(model, BertEmbeddingModel)
@@ -87,8 +87,8 @@ def test_roberta_model_loading_with_params(vllm_runner, monkeypatch):
8787
assert model_config.pooler_config.normalize
8888

8989
# asserts on the tokenizer loaded
90-
assert model_tokenizer.tokenizer_id == "intfloat/multilingual-e5-base"
91-
assert model_tokenizer.tokenizer.model_max_length == 512
90+
assert model_config.tokenizer == "intfloat/multilingual-e5-base"
91+
assert model_tokenizer.model_max_length == 512
9292

9393
def check_model(model):
9494
assert isinstance(model, RobertaEmbeddingModel)
@@ -116,8 +116,7 @@ def test_facebook_roberta_model_loading_with_params(vllm_runner, monkeypatch):
116116
output = vllm_model.embed("Write a short story about a robot that"
117117
" dreams for the first time.\n")
118118

119-
model_tokenizer = vllm_model.llm.llm_engine.tokenizer
120-
assert model_tokenizer.tokenizer_id == model_name
119+
assert vllm_model.llm.llm_engine.model_config.tokenizer == model_name
121120

122121
def check_model(model):
123122
assert isinstance(model, RobertaEmbeddingModel)

0 commit comments

Comments
 (0)