added degrees units #390
Merged
added degrees units #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Jan 23, 2023
| @@ -31,6 +31,8 @@ def test_added_degrees_units(): | |||
| assert ureg("degrees_east") == ureg("degrees") | |||
| assert ureg("degrees_east").to_base_units().units == ureg.radian | |||
|
|
|||
| assert ureg("degrees").to_base_units().units == ureg.radian | |||
dcherian
added a commit
to dcherian/cf-xarray
that referenced
this pull request
Feb 8, 2023
* upstream/main: Support grid_topology, mesh_topology CF roles. (xarray-contrib#420) added degrees units (xarray-contrib#390)
dcherian
added a commit
to Descanonge/cf-xarray
that referenced
this pull request
Feb 22, 2023
* main: (33 commits) Update README.rst Update README.rst v0.8.0 release (xarray-contrib#424) Add sgrid axes parsing (xarray-contrib#421) Add rich repr (xarray-contrib#409) add `cf.grid_mapping_names` (xarray-contrib#391) Update CF standard name table v80 (xarray-contrib#423) Support grid_topology, mesh_topology CF roles. (xarray-contrib#420) added degrees units (xarray-contrib#390) Test and support 3.11 (xarray-contrib#417) Update link to COSIMA tutorial (xarray-contrib#419) Bump mamba-org/provision-with-micromamba from 14 to 15 (xarray-contrib#418) Update whats-new.rst (xarray-contrib#414) [skip-ci] Include data folder (xarray-contrib#416) Update changelog URL updated whats new for release (xarray-contrib#413) Using regex package for match (xarray-contrib#408) Try pytest-pretty (xarray-contrib#410) Update CITATION.cff (xarray-contrib#399) Fix upstream-dev CI (xarray-contrib#406) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add the
degreesunit if a grid_mapping is present. This is recommended by CF conventions:This is mainly to adapt the
cfformat. The original degrees unit would be printed asdeg:however, this PR changes this to:
I don't think this would cause a conflict? Thanks for cosidering this!