Skip to content

Improve rename_like #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2021
Merged

Improve rename_like #222

merged 8 commits into from
May 27, 2021

Conversation

malmans2
Copy link
Member

@malmans2 malmans2 commented May 1, 2021

rename_like also updates the bounds and cell_measures attributes.

@codecov
Copy link

codecov bot commented May 1, 2021 •
edited
Loading

Codecov Report

Merging #222 (3202623) into main (24bf4d3) will increase coverage by 0.04%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   96.45%   96.50%   +0.04%     
==========================================
  Files          14       14              
  Lines        1609     1630      +21     
==========================================
+ Hits         1552     1573      +21     
  Misses         57       57
Flag Coverage Δ
unittests 96.50% <97.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/accessor.py 95.44% <96.77%> (+0.08%) ⬆️
cf_xarray/tests/test_accessor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bf4d3...3202623. Read the comment docs.

dcherian
dcherian requested changes May 26, 2021
View reviewed changes
@dcherian
Copy link
Contributor

Docs failure is related to this PR

@malmans2
Copy link
Member Author

malmans2 commented May 27, 2021 •
edited
Loading

Docs failure is related to this PR

I don't think so, main is failing as well. I'm not sure what changed (I guess in xarray?) but this would fix it: #227 (comment)

@dcherian dcherian merged commit dfde8e3 into main May 27, 2021
@dcherian dcherian deleted the improve_rename_like branch May 27, 2021 13:59
dcherian added a commit to jukent/cf-xarray that referenced this pull request Jun 8, 2021
@dcherian
Merge branch 'main' into facetgrid
1833a22 
* main: (57 commits)
  Add CITATION.cff, tributors, zenodo.json (xarray-contrib#231)
  Add zenodo badge
  Improve `rename_like` (xarray-contrib#222)
  Don't apply mappers to DataArrays (xarray-contrib#227)
  Add unit support to cf-xarray (xarray-contrib#197)
  Update README.rst
  Add earthcube 2021 notebook link to readme
  v0.5.2
  Some CMIP6 support
  Add pooch to binder environment (xarray-contrib#223)
  `add_bounds` uses `keys` rather than `dims` (xarray-contrib#221)
  Add .cf.formula_terms (xarray-contrib#213)
  Update whats-new.rst (xarray-contrib#217)
  add bounds property (xarray-contrib#214)
  Update some tests.
  Compile regexes
  Fix black
  Add __version__ (xarray-contrib#208)
  add skip to rename_like (xarray-contrib#206)
  Refactor out coordinate criteria to criteria.py (xarray-contrib#205)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malmans2 @dcherian