Skip to content

Commit ff0a364

Browse files
committed
fix backward process of rope
rope backward process was broken after YaRN RoPE (ggml-org#2268) implementation, due to missing changes in backward functions. the code for the backward process is nearly identically to the forward process: the only difference is the sign of the sin-values. to avoid future regressions remove the near-duplicate backward functions and reuse the forward code: for this a new function argument `bool forward` was added to `ggml_compute_forward_rope_f32` and `ggml_compute_forward_rope_f16`. the sin-values will be negated when forward is false.
1 parent 2833a6f commit ff0a364

File tree

2 files changed

+89
-254
lines changed

2 files changed

+89
-254
lines changed

0 commit comments

Comments
 (0)