Skip to content

allow pandas kwargs (json) in request.GET #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2015
Merged

allow pandas kwargs (json) in request.GET #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3851914
allow pandas kwargs (json) in request.GET
kevinmickey Aug 2, 2015
17929ea
have get_pandas_kwargs consistently take 3 args
kevinmickey Aug 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions rest_pandas/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def render(self, data, accepted_media_type=None, renderer_context=None):
raise Exception("Data frame is missing %s property!" % name)
self.init_output()
args = self.get_pandas_args(data)
kwargs = self.get_pandas_kwargs(data)
kwargs = self.get_pandas_kwargs(data, renderer_context)
function(*args, **kwargs)
return self.get_output()

Expand All @@ -48,7 +48,7 @@ def get_output(self):
def get_pandas_args(self, data):
return [self.output]

def get_pandas_kwargs(self, data):
def get_pandas_kwargs(self, data, renderer_context):
return {}


Expand Down Expand Up @@ -76,7 +76,7 @@ class PandasCSVRenderer(PandasBaseRenderer):
media_type = "text/csv"
format = "csv"

def get_pandas_kwargs(self, data):
def get_pandas_kwargs(self, data, renderer_context):
return {'encoding': self.charset}


Expand All @@ -96,10 +96,17 @@ class PandasJSONRenderer(PandasBaseRenderer):
media_type = "application/json"
format = "json"

def get_pandas_kwargs(self, data):
def get_pandas_kwargs(self, data, renderer_context):
request = renderer_context['request']
orient = request.GET.get('orient','')
date_format = request.GET.get('date_format','')
if orient not in {'split','records','index','columns','values'}:
orient = 'records'
if date_format not in {'epoch','iso'}:
date_format = 'iso'
return {
'orient': 'records',
'date_format': 'iso',
'orient': orient,
'date_format': date_format,
}


Expand Down Expand Up @@ -135,7 +142,7 @@ def init_output(self):
def get_pandas_args(self, data):
return []

def get_pandas_kwargs(self, data):
def get_pandas_kwargs(self, data, renderer_context):
return {'ax': self.ax}

def get_output(self):
Expand Down