-
Notifications
You must be signed in to change notification settings - Fork 144
Conversation
7371a92
to
439db6c
Compare
439db6c
to
c38c758
Compare
Hey @samueljseay or @octaedro is one of you able to double check this? It renders well for me.
|
relatedTarget = event.relatedTarget; | ||
} else if ( this.toggleButtonRef.current ) { | ||
const ownerDoc = this.toggleButtonRef.current.ownerDocument; | ||
relatedTarget = ownerDoc ? ownerDoc.activeElement : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a lint error that doesn't like the use of document.activeElement
and suggests to use ownerDocument
instead.
@@ -4,6 +4,7 @@ module.exports = { | |||
require.resolve( './custom.js' ), | |||
'plugin:@wordpress/eslint-plugin/recommended', | |||
], | |||
parser: '@typescript-eslint/parser', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the typescript-eslint parser as was suggested here
To fix this import error:
Syntax error in type: import('@wordpress/element').WPElement} WPElement jsdoc/valid-types
An import statement like this was done in more place (you can see the errors in the initial travis ci output).
@louwie17 sorry I missed the ping on this one. Your changes look good, but alas its been open a while so there are conflicts. Do you wanna take a look at those? |
This PR contains the following updates:
4.17.0
->4.20.0
3.1.0
->3.3.0
2.6.0
->2.7.0
10.0.0
->10.2.0
11.0.0
->11.1.3
3.13.1
->3.23.1
1.6.0
->1.7.0
4.16.1
->4.26.1
1.10.1
->1.20.1
3.9.0
->3.13.0
2.9.0
->2.16.0
4.6.0
->4.16.1
2.13.1
->2.19.0
7.1.0
->7.4.0
2.8.0
->2.11.0
2.7.0
->2.10.0
3.11.0
->3.17.0
2.0.0
->2.9.0
2.11.0
->2.18.0
2.22.0
->2.24.1
1.3.0
->1.6.0
0.3.0
->0.4.0
12.0.0
->12.6.1
2.13.0
->2.21.0
2.15.1
->2.25.1
Release Notes
WordPress/gutenberg
v4.20.0
Compare Source
v4.19.0
Compare Source
v4.18.1
Compare Source
v4.18.0
Compare Source
Renovate configuration
📅 Schedule: "before 3am on wednesday" (UTC).
🚦 Automerge: Disabled due to failing status checks.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.