Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Fix code-coverage reports for ts/tsx #80

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

zinserjan
Copy link
Contributor

This PR applys sourcemaps for code-coverage reports.

Before:

--------------------------|----------|----------|----------|----------|----------------|
File                      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
--------------------------|----------|----------|----------|----------|----------------|
All files                 |    34.69 |    30.77 |     37.5 |    36.17 |                |
 App.tsx                  |    80.95 |    57.14 |       75 |    89.47 |            4,5 |
 index.tsx                |        0 |      100 |      100 |        0 |2,3,4,5,6,7,8,9 |
 registerServiceWorker.ts |        0 |        0 |        0 |        0 |... 49,50,51,55 |
--------------------------|----------|----------|----------|----------|----------------|

After:

--------------------------|----------|----------|----------|----------|----------------|
File                      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
--------------------------|----------|----------|----------|----------|----------------|
All files                 |    24.32 |        0 |       20 |    22.22 |                |
 App.tsx                  |      100 |      100 |      100 |      100 |                |
 index.tsx                |        0 |      100 |      100 |        0 |2,3,4,5,6,7,8,9 |
 registerServiceWorker.ts |        0 |        0 |        0 |        0 |... 49,50,51,55 |
--------------------------|----------|----------|----------|----------|----------------|

@ChristopherHoffman
Copy link

This fix would be highly appreciated. You never realized how just helpful the code coverage reports are until they give you wrong information, and you have to track down uncovered code yourself.

@wmonk
Copy link
Owner

wmonk commented Jun 23, 2017

@zinserjan can you fix this conflict please 😄

@zinserjan zinserjan force-pushed the fix-code-coverage branch from e953721 to 106599d Compare June 23, 2017 10:15
@zinserjan
Copy link
Contributor Author

@wmonk done

@wmonk wmonk merged commit d9e728b into wmonk:master Jun 23, 2017
@zinserjan zinserjan deleted the fix-code-coverage branch June 23, 2017 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants