Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

[Question] What does typesPatches do in tsconfig.json? #89

Closed
pselden opened this issue Jun 19, 2017 · 3 comments · Fixed by #113
Closed

[Question] What does typesPatches do in tsconfig.json? #89

pselden opened this issue Jun 19, 2017 · 3 comments · Fixed by #113

Comments

@pselden
Copy link

pselden commented Jun 19, 2017

https://github.com/wmonk/create-react-app-typescript/blob/master/packages/react-scripts/template/tsconfig.json#L30

Just curious what this line does -- I've never seen it before in a project.
@tko tko mentioned this issue Jun 22, 2017
Open
@wmonk
Copy link
Owner

wmonk commented Jun 23, 2017

This was left over from when I originally created this module. It was a place we stored .d.ts files for modules that either didn't have them, were out of data, or were wrong. It should really be removed now. Hope this helps!

@wmonk wmonk closed this as completed Jun 23, 2017
nareshbhatia added a commit to archfirst/react-mobx-mui-ts-seed that referenced this issue Jul 18, 2017
@nareshbhatia
Removed typePatches from tsconfig.json
ef513ce 
See wmonk/create-react-app-typescript#89
@junosuarez
Copy link
Contributor

I'm still seeing it in https://github.com/wmonk/create-react-app-typescript/blob/master/packages/react-scripts/template/tsconfig.json and in new projects generated when I run create-react-app my-app --scripts-version=react-scripts-ts.

When you say "it should really be removed now," is that describing current state, or something to do in the future?

Would you accept a PR removing this line?

Thanks!

@wmonk
Copy link
Owner

wmonk commented Jul 20, 2017

@js-n I would happily accept a PR for it! 👍

junosuarez added a commit to junosuarez/create-react-app-typescript that referenced this issue Jul 20, 2017
@junosuarez
remove typePatches
ea3fb7b 
closes wmonk#89
@junosuarez junosuarez mentioned this issue Jul 20, 2017
Merged
@tansongyang tansongyang mentioned this issue Aug 9, 2017
Open
sven3270350 added a commit to sven3270350/react-typescript that referenced this issue Aug 11, 2022
@sven3270350
remove typePatches
55dcb01 
closes wmonk/create-react-app-typescript#89
OrdinalKing pushed a commit to OrdinalKing/create-react-app-ts-redux-saga-mui that referenced this issue Aug 26, 2022
@junosuarez
remove typePatches
f80b73c 
closes wmonk/create-react-app-typescript#89
SmartCodiDev added a commit to SmartCodiDev/redux-saga-mui that referenced this issue May 31, 2024
@SmartCodiDev
remove typePatches
4fab64e 
closes wmonk/create-react-app-typescript#89
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove typePatches junosuarez/create-react-app-typescript
3 participants
@wmonk @pselden @junosuarez