Skip to content

Revert, move to specs and publish the typescript vesion #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@
*.d.js
# include the .d.ts files
!*.d.ts
# ignore the .js files in the specs folder and include the .ts files and include the .ts files
specs/**/*.js
!specs/**/*.ts
2 changes: 1 addition & 1 deletion lib/components/HighlighterOverlayView/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {processColor, StyleSheet, Modal, ViewStyle} from 'react-native';
// Import the Codegen specification for New Architecture
import HighlighterViewNativeComponent, {
HighlightViewTagParams as NativeHighlightViewTagParams
} from './HighlighterViewNativeComponent';
} from '../../specs/HighlighterViewNativeComponent';

const DefaultOverlayColor = 'rgba(0, 0, 0, 0.5)';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, {PureComponent} from 'react';
import ReactNative, {NativeModules} from 'react-native';
// Import the Codegen specification for New Architecture
import KeyboardTrackingViewNativeComponent from './KeyboardTrackingViewNativeComponent';
import KeyboardTrackingViewNativeComponent from '../../../specs/KeyboardTrackingViewNativeComponent';
import {KeyboardTrackingViewProps} from './index';

const KeyboardTrackingViewTempManager = NativeModules.KeyboardTrackingViewTempManager;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
// import type {ViewProps} from 'react-native';
import {requireNativeComponent, type ViewProps} from 'react-native';
import type {
Float,
Int32,
WithDefault
} from 'react-native/Libraries/Types/CodegenTypes';
// import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
import type {ViewProps} from 'react-native';
// import {requireNativeComponent, type ViewProps} from 'react-native';
import type {Float, Int32, WithDefault} from 'react-native/Libraries/Types/CodegenTypes';
import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';

export interface HighlightFrame {
x: Float;
Expand Down Expand Up @@ -75,8 +71,8 @@ export interface NativeProps extends ViewProps {
innerPadding?: WithDefault<Float, 0>;
}

// export default codegenNativeComponent<NativeProps>('HighlighterView');
export default codegenNativeComponent<NativeProps>('HighlighterView');

const HighlighterViewNativeComponent = requireNativeComponent<NativeProps>('HighlighterView');
// const HighlighterViewNativeComponent = requireNativeComponent<NativeProps>('HighlighterView');

export default HighlighterViewNativeComponent;
// export default HighlighterViewNativeComponent;
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// import type {ViewProps} from 'react-native';
import {requireNativeComponent, type ViewProps} from 'react-native';
import type {ViewProps} from 'react-native';
// import {requireNativeComponent, type ViewProps} from 'react-native';
import type {Int32, WithDefault} from 'react-native/Libraries/Types/CodegenTypes';
// import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';
import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';

export interface NativeProps extends ViewProps {
/**
Expand Down Expand Up @@ -67,8 +67,8 @@ export interface NativeProps extends ViewProps {
usesBottomTabs?: WithDefault<boolean, false>;
}

// export default codegenNativeComponent<NativeProps>('KeyboardTrackingViewTemp');
export default codegenNativeComponent<NativeProps>('KeyboardTrackingViewTemp');

const KeyboardTrackingViewNativeComponent = requireNativeComponent<NativeProps>('KeyboardTrackingViewTemp');
// const KeyboardTrackingViewNativeComponent = requireNativeComponent<NativeProps>('KeyboardTrackingViewTemp');

export default KeyboardTrackingViewNativeComponent;
// export default KeyboardTrackingViewNativeComponent;
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"react-native-redash": "^12.0.3",
"semver": "^5.5.0",
"tinycolor2": "^1.4.2",
"uilib-native": "5.0.0-snapshot.7207",
"uilib-native": "5.0.0-snapshot.7212",
"url-parse": "^1.2.0",
"wix-react-native-text-size": "1.0.9"
},
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10928,7 +10928,7 @@ __metadata:
shell-utils: ^1.0.10
tinycolor2: ^1.4.2
typescript: 5.0.4
uilib-native: 5.0.0-snapshot.7207
uilib-native: 5.0.0-snapshot.7212
url-parse: ^1.2.0
wix-react-native-text-size: 1.0.9
peerDependencies:
Expand Down Expand Up @@ -12560,16 +12560,16 @@ __metadata:
languageName: node
linkType: hard

"uilib-native@npm:5.0.0-snapshot.7207":
version: 5.0.0-snapshot.7207
resolution: "uilib-native@npm:5.0.0-snapshot.7207"
"uilib-native@npm:5.0.0-snapshot.7212":
version: 5.0.0-snapshot.7212
resolution: "uilib-native@npm:5.0.0-snapshot.7212"
dependencies:
lodash: ^4.17.21
prop-types: ^15.5.10
peerDependencies:
react: ">=17.0.1"
react-native: ">=0.64.1"
checksum: 3246a839f411acc4b05507eb3f1c1eea350b38268c8167e68fe6ca123985a53b848578df33bf738aee230cd2ef535bc41bd975d1e1f848e7263ff59ee7ae04e9
checksum: f293839cebb6b8dca255de9b02dcf27f36892aa8d2c97ae1445c4e8506d43db03cd95758ae7685f642fce051bff016667a91632083d48ac6581dc101691f3365
languageName: node
linkType: hard

Expand Down