Skip to content

Picker - migrate prop deprecation end #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 15, 2025

Conversation

adids1221
Copy link
Contributor

@adids1221 adids1221 commented May 20, 2025

Description

Picker - migrate, getItemLabel, getItemLabel prop deprecation end, remove the migrate, getItemLabel, getItemLabel prop from component usage.
Based on #3718

Changelog

Picker - migrate, getItemLabel, getItemLabel prop deprecation end.

Additional info

MADS-4195

Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l May 25, 2025
@adids1221 adids1221 requested a review from M-i-k-e-l June 3, 2025 07:02
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jun 3, 2025
@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Jun 3, 2025
@adids1221
Copy link
Contributor Author

@M-i-k-e-l you assigned me without any comment ?

@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jun 4, 2025
@M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l you assigned me without any comment ?

It was pending, look at the PM and improve the docs please

Comment on lines 82 to 83
- `getItemValue` - Removed (value extraction is now automatic from `item.value`)
- `getItemLabel` - Removed (label extraction is now automatic from `item.label`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: "Use item.<X> to get <X>"

@adids1221 adids1221 requested a review from M-i-k-e-l June 10, 2025 08:07
@M-i-k-e-l M-i-k-e-l assigned adids1221 and unassigned M-i-k-e-l Jun 10, 2025
@adids1221 adids1221 requested a review from M-i-k-e-l June 12, 2025 08:53
@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Jun 12, 2025
@M-i-k-e-l M-i-k-e-l merged commit 4a3f9b8 into v8 Jun 15, 2025
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the infra/v8_picker_migrate_prop_migration branch June 15, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants