Skip to content

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Sep 27, 2023

Description of change

fix: make disabling metal on build work

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in CONTRIBUTING.md (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto September 27, 2023 19:17
@giladgd giladgd self-assigned this Sep 27, 2023
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit 03ec18b into master Sep 27, 2023
@giladgd giladgd deleted the gilad/makeDisablingMetalWork branch September 27, 2023 20:37
@github-actions
Copy link

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants