Skip to content

feat: fall back to build from source if prebuilt binary loading fails #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat: fall back to build from source if prebuilt binary loading fails #54

merged 1 commit into from
Sep 26, 2023

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Sep 26, 2023

Description of change

  • feat: fall back to build from source if prebuilt binary loading fails

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in CONTRIBUTING.md (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto September 26, 2023 19:39
@giladgd giladgd self-assigned this Sep 26, 2023
ido-pluto
ido-pluto approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit d99e3b0 into master Sep 26, 2023
@giladgd giladgd deleted the gilad/buildFromSourceIfBinaryLoadFail branch September 26, 2023 19:55
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giladgd @ido-pluto