Skip to content

feat: shorter model URIs #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 30, 2025
Merged

feat: shorter model URIs #421

merged 10 commits into from
Jan 30, 2025

Conversation

giladgd
Copy link
Member

@giladgd giladgd commented Jan 28, 2025 •
edited
Loading

Description of change

  • feat: shorter model URIs (documentation: Model URIs)
  • feat: Hugging Face URL shortcuts (documentation: Shortcuts for quick experimentation)
  • feat: did you mean "<URI>"? help log
  • fix: show a loader when resolving a URI from the CLI

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd marked this pull request as ready for review January 30, 2025 00:54
@giladgd giladgd self-assigned this Jan 30, 2025
@giladgd giladgd requested a review from ido-pluto January 30, 2025 00:54
ido-pluto
ido-pluto approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd force-pushed the gilad/shorterModelUri branch from 526a8b5 to 7b56fba Compare January 30, 2025 21:54
@giladgd giladgd merged commit 73454d9 into master Jan 30, 2025
14 of 15 checks passed
@giladgd giladgd deleted the gilad/shorterModelUri branch January 30, 2025 23:33
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0xdevalias 0xdevalias mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giladgd @ido-pluto