Skip to content

fix: load image urls properly also outside GitHub #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2023
Merged

fix: load image urls properly also outside GitHub #35

merged 1 commit into from
Sep 2, 2023

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Sep 2, 2023

Description of change

fix: load image urls properly also outside GitHub

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in CONTRIBUTING.md (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto September 2, 2023 22:49
@giladgd giladgd self-assigned this Sep 2, 2023
@giladgd giladgd merged commit cf1f5f1 into master Sep 2, 2023
@giladgd giladgd deleted the gilad/fixImageUrlsOutsideOfGithub branch September 2, 2023 22:49
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto Awaiting requested review from ido-pluto

Assignees

@giladgd giladgd

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giladgd