Skip to content

docs(guides,config) asset module follow up #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2019
Merged

docs(guides,config) asset module follow up #3382

merged 10 commits into from
Dec 2, 2019

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Dec 1, 2019 •
edited
Loading

  • add sort to fix the page
  • refactor types, wording and structure of the configuration options
  • tidy up the guide and re-link to new paragraph

@netlify
Copy link

netlify bot commented Dec 1, 2019 •
edited
Loading

Preview is ready

Built with commit 6613b5a

https://deploy-preview-3382--webpackjsorg-netlify.netlify.com

EugeneHlushko
EugeneHlushko commented Dec 2, 2019
View reviewed changes
@EugeneHlushko
Copy link
Member Author

EugeneHlushko commented Dec 2, 2019 •
edited
Loading

Unfortunately there was a contribution to fix a typo which was already fixed here and making a conflict in these changes even though this PR was added 23 hours ago, and the conflicting change was added 6 hours ago. We should avoid this in future @montogeek
#3386

EugeneHlushko
EugeneHlushko commented Dec 2, 2019
View reviewed changes
EugeneHlushko
EugeneHlushko commented Dec 2, 2019
View reviewed changes
@montogeek
Copy link
Member

@EugeneHlushko Sorry

montogeek
montogeek reviewed Dec 2, 2019
View reviewed changes
montogeek
montogeek reviewed Dec 2, 2019
View reviewed changes
montogeek
montogeek reviewed Dec 2, 2019
View reviewed changes
montogeek
montogeek reviewed Dec 2, 2019
View reviewed changes
src/content/configuration/module.mdx
A mimetype for data-url. Resolves from module resource extension by default

## `Rule.generator.dataUrl` as a function
When used a a function, it executes for every module and must return a data URI string.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When used a a function, it executes for every module and must return a data URI string.
When used as a function, it executes for every module and must return a data URI string.

@EugeneHlushko
Copy link
Member Author

Great suggestions, ty!

@EugeneHlushko EugeneHlushko merged commit 7cefed8 into master Dec 2, 2019
@EugeneHlushko EugeneHlushko deleted the asset-modules/followup branch December 2, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

Assignees
No one assigned
Labels
Configuration Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EugeneHlushko @montogeek