Skip to content

Fetch supporters with Open Collective GraphQL API #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

znarf
Copy link
Contributor

@znarf znarf commented May 21, 2019

Expected behavior changes:

  • the data is not computed the same, so it can be there is small differences with the current data. before merging we need to assess if the result is what's expected
  • backers without an avatar get a default one with their initials

Todo:

  • support firstDonation
  • de-duplication (due to supporters with multiple orders)
  • pagination (limited to 1000 now)

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@netlify
Copy link

netlify bot commented May 21, 2019

Preview is ready

Built with commit 1ef1a61

https://deploy-preview-3054--webpackjsorg-netlify.netlify.com

@znarf znarf force-pushed the enhancement/opencollective-graphql branch from e092661 to c11bc1d Compare May 21, 2019 19:47
@znarf znarf force-pushed the enhancement/opencollective-graphql branch from c11bc1d to 1ef1a61 Compare May 21, 2019 20:17
@znarf znarf marked this pull request as ready for review May 21, 2019 20:37
@EugeneHlushko
Copy link
Member

Well, it works as expected i would say, code looks good too.
But +80 −12, is that what future is 😅

I'll leave it to the rest of maintainers

@montogeek
Copy link
Member

It is fine

@montogeek
Copy link
Member

I don't see the request in the preview version, but the supporters list is there, maybe cache?

@EugeneHlushko
Copy link
Member

We fetch them during build time, this is only run on node

@EugeneHlushko EugeneHlushko merged commit 52c94bd into webpack:master May 22, 2019
@EugeneHlushko
Copy link
Member

Thanks, well structured PR too!

@znarf
Copy link
Contributor Author

znarf commented May 22, 2019

Thank you for merging!

@EugeneHlushko Sorry, GraphQL is a bit more verbose but I think this is worth it!

Don't hesitate if you have any feedback and feature request for the Open Collective API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants