Skip to content

Fix typo in code splitting documentation #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

Fix typo in code splitting documentation #3045

merged 1 commit into from
May 16, 2019

Conversation

foolip
Copy link
Contributor

@foolip foolip commented May 15, 2019 •
edited
Loading

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Remove these instructions from your PR as they are for your eyes only.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@netlify
Copy link

netlify bot commented May 15, 2019

Preview is ready

Built with commit 85f7996

https://deploy-preview-3045--webpackjsorg-netlify.netlify.com

@anshumanv
Copy link
Member

anshumanv commented May 15, 2019 •
edited
Loading

Thanks for your contribution, please sign the CLA :)

@foolip
Copy link
Contributor Author

foolip commented May 15, 2019

I'm looking into how to sign it, I suspect I can't sign as an individual as I work for Google.

@montogeek montogeek closed this May 16, 2019
@montogeek montogeek reopened this May 16, 2019
@foolip foolip closed this May 16, 2019
@foolip foolip reopened this May 16, 2019
@foolip
Copy link
Contributor Author

foolip commented May 16, 2019

Alright, CLA signed, it was allowed.

@montogeek montogeek merged commit 8917a9b into webpack:master May 16, 2019
@montogeek
Copy link
Member

Thanks!

@foolip foolip deleted the patch-2 branch May 16, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@anshumanv anshumanv anshumanv approved these changes

Assignees
No one assigned
Labels
Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foolip @jsf-clabot @anshumanv @montogeek @hiroppy