Skip to content

Update installation.md #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2019
Merged

Update installation.md #2817

merged 8 commits into from
Mar 6, 2019

Conversation

lkounadis
Copy link
Contributor

@lkounadis lkounadis commented Feb 20, 2019

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Remove these instructions from your PR as they are for your eyes only.

@jsf-clabot
Copy link

jsf-clabot commented Feb 20, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@lkounadis
Copy link
Contributor Author

I dont really agree with this because there are some (junior) devs who may not understand. thats why I wanted to elaborate on this, Since there is no other movement lets proceed with your change.

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this phrasing. Lets get another approving review because i have contributed to this and cant review something i wrote.

@EugeneHlushko EugeneHlushko requested a review from montogeek March 6, 2019 09:42
@montogeek
Copy link
Member

Thanks!

@montogeek montogeek merged commit d94b1ef into webpack:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants