Skip to content

docs(guides): change var to let and move lodash under dependencies #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2018
Merged

docs(guides): change var to let and move lodash under dependencies #2409

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4ee08b
docs(guides): change var to let
sudarsangp Jul 30, 2018
4dae5e3
docs(guides): move lodash under dependencies
sudarsangp Jul 30, 2018
64c2a74
docs(guides): change var to let all occurrences
sudarsangp Jul 30, 2018
3ffb765
docs(guides): remove comment based on code review
sudarsangp Aug 2, 2018
1171c8d
Merge branch 'master' into guides-getting-started
montogeek Aug 2, 2018
f801687
Merge branch 'master' into guides-getting-started
sudarsangp Aug 4, 2018
fe071ec
Merge branch 'master' into guides-getting-started
montogeek Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/content/guides/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ __src/index.js__

``` javascript
function component() {
var element = document.createElement('div');
let element = document.createElement('div');

// Lodash, currently included via a script, is required for this line to work
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down Expand Up @@ -148,10 +148,9 @@ __src/index.js__
+ import _ from 'lodash';
+
function component() {
var element = document.createElement('div');
let element = document.createElement('div');

- // Lodash, currently included via a script, is required for this line to work
+ // Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');

return element;
Expand Down Expand Up @@ -291,7 +290,9 @@ __package.json__
"license": "ISC",
"devDependencies": {
"webpack": "^4.0.1",
"webpack-cli": "^2.0.9",
"webpack-cli": "^2.0.9"
},
"dependencies": {
"lodash": "^4.17.5"
}
}
Expand Down