Skip to content

Update docs for default value for stats.toString({colors}) #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

Update docs for default value for stats.toString({colors}) #1835

merged 1 commit into from
Feb 23, 2018

Conversation

connorjclark
Copy link
Contributor

@connorjclark connorjclark commented Feb 16, 2018 •
edited
Loading

Doc incorrectly states the default value is true, but it is false. See https://github.com/webpack/webpack/blob/master/lib/Stats.js#L512

skipjack
skipjack approved these changes Feb 21, 2018
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@skipjack skipjack merged commit c17fcb7 into webpack:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipjack skipjack skipjack approved these changes

Assignees
No one assigned
Labels
Configuration Correction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjclark @skipjack