Skip to content

Guides Cleanup #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Guides Cleanup #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fecbcda
docs(guides): remove to incomplete guides
skipjack Jun 24, 2017
8a0edb8
docs(guides): move the comparison guide out of the guides section
skipjack Jun 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/footer/footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ export default (props) => {
<footer className="footer">
<Container className="footer__inner">
<section className="footer__left">
<Link className="footer__link" to="/guides/getting-started">Get Started</Link>
<Link className="footer__link" to="/guides/getting-started">Getting Started</Link>
<Link className="footer__link" to="/organization">Organization</Link>
<Link className="footer__link" to="/support">Support</Link>
<Link className="footer__link" to="/guides/comparison">Comparison</Link>
<Link className="footer__link" to="/comparison">Comparison</Link>
</section>

<section className="footer__middle">
Expand Down
0 content/guides/comparison.md → content/comparison.md
View file
Open in desktop
File renamed without changes.
24 changes: 0 additions & 24 deletions content/guides/build-performance.md
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions content/guides/compatibility.md
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions content/guides/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ contributors:
- TheDutchCoder
---

As you may already know, webpack is used to compile JavaScript modules. Once [installed](/guides/installation), you can interface with webpack either from its [CLI](/api/cli) or [API](/api/node). If you're still new to webpack, please read through the [core concepts](/concepts) and [this comparison](/guides/comparison) to learn why you might use it over the other tools that are out in the community.
As you may already know, webpack is used to compile JavaScript modules. Once [installed](/guides/installation), you can interface with webpack either from its [CLI](/api/cli) or [API](/api/node). If you're still new to webpack, please read through the [core concepts](/concepts) and [this comparison](/comparison) to learn why you might use it over the other tools that are out in the community.


## Basic Setup
Expand Down Expand Up @@ -109,7 +109,7 @@ __src/index.js__
+
function component() {
var element = document.createElement('div');

- // Lodash, currently included via a script, is required for this line to work
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was on purpose, as it shows the user that in this case lodash is imported through a <script> tag, whereas later on it's imported by webpack.

Would you mind leaving it in (or maybe clarify it)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sorry about that. I think I either misunderstood or took this out accidentally. Will remove this change tonight.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheDutchCoder just double-checked this. It's a bit confusing because your viewing a code block of the syntax highlighting language diff within a GitHub change diff. It tripped me up too when I first saw your comment. The diff from source tree is easier to understand:

image

It's only the blank line above that comment that changed. Just a minor editorconfig autofix 👍 . Your comment should remain untouched.

+ // Lodash, now imported by this script
element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down