Skip to content

Fixed examples for CLI-only DevServer options #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ingver
Copy link

@ingver ingver commented May 6, 2017

I have changed all JS examples for CLI-only DevServer options to Bash to avoid confusion.
I've also noticed that port option despite CLI-only flag in documentation could be used inside JS-config too.

Changed all JS examples for CLI-only DevServer options to Bash
@simon04
Copy link
Collaborator

simon04 commented May 7, 2017

Thanks for your contribution! I agree that makes examples more understandable.

However, the "CLI only" tags seem to be greatly outdated. When reading the source code, firstly the webpack.config.js is being parsed, and that config is updated based on the commandline arguments. So I think, most/all "CLI only" tags should be droppen. @webpack/documentation-team can you confirm?

@bebraw
Copy link
Contributor

bebraw commented May 7, 2017

@SpaceK33z Any thoughts on this?

@simon04 simon04 requested a review from SpaceK33z May 26, 2017 08:06
@skipjack
Copy link
Collaborator

However, the "CLI only" tags seem to be greatly outdated. When reading the source code, firstly the webpack.config.js is being parsed, and that config is updated based on the commandline arguments. So I think, most/all "CLI only" tags should be droppen. @webpack/documentation-team can you confirm?

@simon04 I agree... also this is all within the /configuration section of our documentation so either it should be removed or moved to a true /cli section of our docs once we have one.

@skipjack
Copy link
Collaborator

skipjack commented Jul 2, 2017

@SpaceK33z should we just drop all these CLI flags and simply link to somewhere within the webpack-dev-server repository?

@skipjack
Copy link
Collaborator

skipjack commented Aug 1, 2017

Closing in favor of #1468 which was just merged.

@skipjack skipjack closed this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants