Added info about pitfall for externals #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some info about a pitfall mentioned in webpack/webpack#4771 which is good to keep in mind until the issue is fixed.
skipjack
approved these changes
Apr 26, 2017
There was a problem hiding this comment.
LGTM
@richardsimko thanks for this addition! The only thing I'd say is that if you PR something to webpack that removes the need for this, please come back and remove this bit from the docs.
|
I will! The change in webpack will most likely only only add an error message and makanother issue easier to discover. |
richardsimko
pushed a commit
to richardsimko/webpack.js.org
that referenced
this pull request
Jul 3, 2017
…been fixed in webpack
skipjack
pushed a commit
that referenced
this pull request
Jul 4, 2017
This tip is no longer necessary as webpack/webpack#4771 was fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some info about a pitfall mentioned in webpack/webpack#4771 which is good to keep in mind until the issue is fixed.