Dev - Should Support Files be Ignored?

[jeremenichelli]

I just did a clean clone, run npm install, then npm start and these two files appeared as added:

• src/components/Support/support-backers.json
• src/components/Support/support-sponsors.json

Should they be added to .gitignore?

[skipjack]

They should be and it looks like they already are:

https://github.com/webpack/webpack.js.org/blob/master/.gitignore#L5-L7

However I'm seeing the same issue.

[jeremenichelli]

Yeap, they are. Super weird. Don't know if it's cached or an encoding discrepancy.

[skipjack]

Fixed in #1555 ... will merge as soon as the build passes.

[skipjack]

Just some git weirdness left over from the restructuring.

[skipjack]

I also simplified the .gitignore a bit. I think we may want to follow some paradigm for all our "generated" files. Maybe prefix them with an underscore or two so we can just ignore a simple pattern (e.g. __backers.json and in .gitignore => __*).

Then we could do away with the generated folder and just mention in CONTRIBUTING.md and the writer's guide that these files are auto-generated and should not be edited manually.

[jeremenichelli]

Yeah, I was about to suggest something like that, or __fetched__ prefix, to be more obvious..

[skipjack]

Sounds good. Feel free to dig into that if you have time.

cc @pierreneter